Store a UniqueAVFrame in the blocks frame handle - #1596
Closed
NicolasHug wants to merge 1 commit into
Closed
Conversation
🔗 Helpful Links🧪 See artifacts and rendered test results at hud.pytorch.org/pr/meta-pytorch/torchcodec/1596
Note: Links to docs will display an error until the docs builds have been completed. ❗ 1 Active SEVsThere are 1 currently active SEVs. If your PR is affected, please view them below: ❌ 1 New FailureAs of commit 7f264c8 with merge base 3f7692b ( NEW FAILURE - The following job has failed:
This comment was automatically generated by Dr. CI and updates every 15 minutes. |
meta-cla
Bot
added
the
CLA Signed
The frame handle held a raw AVFrame*, so _blocks_convert_frame() had to build a UniqueAVFrame around a pointer the handle already owned and then release() it again to undo the fabricated second owner. It only worked because nothing downstream acted on that ownership. Hold a UniqueAVFrame instead. It's an ordinary C++ object whose destructor calls av_frame_free, so the generic wrap_pointer_to_tensor<T> handle used by the other blocks types applies and the bespoke AVFrame wrapper goes away. _blocks_convert_frame() then has a UniqueAVFrame to pass by reference, with no temporary owner in sight. Costs one small allocation per frame for the wrapper object.
NicolasHug
force-pushed
the
blocks_frame_handle
branch
from
August 3, 2026 21:33
19d2c3d to
7f264c8
Compare
Contributor
Author
|
Superseded by #1598 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The frame handle held a raw AVFrame*, so _blocks_convert_frame() had to
build a UniqueAVFrame around a pointer the handle already owned and then
release() it again to undo the fabricated second owner. It only worked
because nothing downstream acted on that ownership.
Hold a UniqueAVFrame instead. It's an ordinary C++ object whose destructor
calls av_frame_free, so the generic wrap_pointer_to_tensor handle used
by the other blocks types applies and the bespoke AVFrame wrapper goes
away. _blocks_convert_frame() then has a UniqueAVFrame to pass by
reference, with no temporary owner in sight.
Costs one small allocation per frame for the wrapper object.
Stack created with GitHub Stacks CLI • Give Feedback 💬